Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Travis CI test for pip installation on OSX #784

Closed
danielhers opened this issue Aug 15, 2017 · 2 comments
Closed

Enable Travis CI test for pip installation on OSX #784

danielhers opened this issue Aug 15, 2017 · 2 comments
Labels
help wanted moderate bug Issues that should be fixed but only affect less common environments or functionality

Comments

@danielhers
Copy link
Collaborator

#596 enabled Travis CI test for pip installation on Linux, but on OSX it doesn't work because libdynet.dylib is not found. This can be resolved by adding its location to DYLD_LIBRARY_PATH. It's not $TRAVIS_BUILD_DIR/build/dynet because the pip installation creates a build directory inside build called something like py3.4-64bit, but instead of trying to figure that out, it should be possible to use the virtualenv, something like $(dirname $(which python))/../lib because it installs it into that location.

I've been trying forever to make the Python bindings work on OSX without requiring DYLD_LIBRARY_PATH, but I can't figure out how to add the lib properly to RUNTIME_LIBRARY_DIRS. Perhaps someone with more Mac experience can help.

@neubig neubig added the moderate bug Issues that should be fixed but only affect less common environments or functionality label Aug 15, 2017
@neubig
Copy link
Contributor

neubig commented Aug 15, 2017

Thanks for the pointer! This would be really nice to fix, so hopefully someone could help. I'll also take a look but I'm a bit swamped at the moment.

@danielhers
Copy link
Collaborator Author

So am I, otherwise I would have done it myself :)
I did open #783, which is related, and took a lot more time than I expected to fix...

danielhers added a commit to danielhers/dynet that referenced this issue Aug 16, 2017
This works when using DYLD_LIBRARY_PATH, which is now done anyway.
danielhers added a commit to danielhers/dynet that referenced this issue Aug 17, 2017
This works when using DYLD_LIBRARY_PATH, which is now done anyway.
@neubig neubig closed this as completed in ff34fe1 Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted moderate bug Issues that should be fixed but only affect less common environments or functionality
Projects
None yet
Development

No branches or pull requests

2 participants