Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: add GitHub action workflow for PRs #18

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

kylejb
Copy link
Member

@kylejb kylejb commented Jun 3, 2022

Description

Create first GitHub Actions workflow, which will execute tests for every PR attempting to merge to main. Tests must passed in order to be allowed to merge.

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feat/310-new-endpoint or bug/322-fix-missing-param.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.

@kylejb kylejb added the devOps Pull Requests related to DevOps work label Jun 3, 2022
@kylejb kylejb requested a review from a team June 3, 2022 11:52
@kylejb kylejb added the in-progress Issue is being worked on label Jun 3, 2022
@kylejb kylejb changed the title devops: add GitHub action workflow for PRs devops: add GitHub action workflow for PRs [WIP] Jun 3, 2022
Grieze
Grieze previously approved these changes Jun 3, 2022
Copy link
Collaborator

@Grieze Grieze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of github workflows and the yml files? I have no idea what they're for. I'm assuming this is for making working with github easier.

@kylejb
Copy link
Member Author

kylejb commented Jun 3, 2022

This is still a work-in-progress. I want to also create a service process to run a postgresql database in order to run tests on for github actions.

What's the point of github workflows and the yml files? I have no idea what they're for. I'm assuming this is for making working with github easier.

The yml files is what GitHub uses to create workflows in our repository. It's particularly useful for automating CI/CD processes. I'd like to incorporate this for our pull requests.

As an example:

  • We create a new Pull Request
  • Workflow starts:
    • installs repository on a new server
    • runs tests on that new server (to mimic production environment)

This will help us catch critical errors earlier on. And it also will help us review each other's PRs; you won't have to run the tests locally yourself.

@kylejb kylejb force-pushed the devops/test-with-github-actions branch 2 times, most recently from 5a3e91e to f71f292 Compare June 4, 2022 19:23
@kylejb kylejb force-pushed the devops/test-with-github-actions branch from e0cfa38 to 827bffb Compare June 4, 2022 19:43
@kylejb kylejb force-pushed the devops/test-with-github-actions branch from 0cfb03d to 171d79d Compare June 4, 2022 19:48
@kylejb kylejb force-pushed the devops/test-with-github-actions branch from 9e0a637 to d31efff Compare June 4, 2022 20:02
@kylejb kylejb force-pushed the devops/test-with-github-actions branch from 1f7d67c to 4971d13 Compare June 4, 2022 20:31
@kylejb kylejb temporarily deployed to test June 4, 2022 20:41 Inactive
@kylejb kylejb removed the in-progress Issue is being worked on label Jun 4, 2022
@kylejb kylejb requested a review from Grieze June 4, 2022 20:45
@kylejb kylejb changed the title devops: add GitHub action workflow for PRs [WIP] devops: add GitHub action workflow for PRs Jun 4, 2022
* feat: create psql db for tests

* feat: run migrations and seed script before tests

* fix(schemas): allow geom as str when seeding

* fix: add github secrets to env

* fix: wait for psql to boot with sleep

* fix: add PYTHONPATH to address module error

* fix: remove coverage script for later
@kylejb kylejb force-pushed the devops/test-with-github-actions branch from 74eab38 to f7e5929 Compare June 4, 2022 20:49
@kylejb kylejb temporarily deployed to test June 4, 2022 20:49 Inactive
@kylejb kylejb temporarily deployed to test June 4, 2022 21:14 Inactive
@kylejb kylejb merged commit 684d61c into main Jun 5, 2022
@kylejb kylejb deleted the devops/test-with-github-actions branch June 5, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devOps Pull Requests related to DevOps work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants