Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(world-map): create and render component #8

Merged
merged 1 commit into from
Jul 14, 2022
Merged

feat(world-map): create and render component #8

merged 1 commit into from
Jul 14, 2022

Conversation

kylejb
Copy link
Member

@kylejb kylejb commented Jul 14, 2022 •
edited
Loading

Description

  • Add leaflet and react-leaflet dependencies to support Map.
  • Add map component and render in upper left hand corner of home page.
  • Map component renders all NDBC buoys and defaults to show Rockaway Beach (NY) for MVP.
  • Replace map placeholder in Figma with image of new map component.

Example

web_map-on-home-page

Documentation

This PR breaks yarn test for app.test.ts and will have to be addressed in #7.

Related Issues

Closes #3

@kylejb
feat(world-map): create and render component
7630718 
* deps: add leaflet and react-leaflet

* feat: add types

* feat: add constants for api routes

* feat: add custom css
@kylejb kylejb added dependencies Pull requests that update a dependency file enhancement Improvements or additions to existing feature labels Jul 14, 2022
@kylejb kylejb requested a review from a team July 14, 2022 11:09
Grieze
Grieze reviewed Jul 14, 2022
View reviewed changes
package.json Show resolved Hide resolved
@kylejb kylejb requested a review from Grieze July 14, 2022 11:59
Grieze
Grieze reviewed Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@Grieze Grieze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most looks good to me, just have a couple of questions.

@kylejb kylejb merged commit cb87d8c into main Jul 14, 2022
@kylejb kylejb deleted the feat/3-map-with-leaflet branch July 14, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grieze Grieze Grieze approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement Improvements or additions to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create map component for home page
2 participants
@kylejb @Grieze