Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In VsCode 1.72 Node was updated to version 20, before this upgrade, it was possible to execute cmd/bat scripts as executable. #758

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

JVApen
Copy link
Contributor

@JVApen JVApen commented Dec 16, 2024

 After this update this was suddenly broken.
 Our use-case for using such a script has to do with the consistency of our clang-tooling.
 We build clang-format, clang-tidy, clangd ... all together and put this in a package manager.
 In the script, we first download these executables (when needed) and than start the downloaded clangd.
 As such, when fixing an issue in clang-tidy, the same issue will get fixed in the clangd exe.
 Without this script, it is impossible to automatically trigger this download and it introduces the risk that we do not update all the tooling to the latest version.

Fixes #683

In this reapply, we quote both the command line and the arguments, such that both can contain spaces. We also introduce the option useScriptAsExecutable, such that this is only enabled when the user wants it. We also provide the default value as boolean instead of string

…t was possible to execute cmd/bat scripts as executable.

     After this update this was suddenly broken.
     Our use-case for using such a script has to do with the consistency of our clang-tooling.
     We build clang-format, clang-tidy, clangd ... all together and put this in a package manager.
     In the script, we first download these executables (when needed) and than start the downloaded clangd.
     As such, when fixing an issue in clang-tidy, the same issue will get fixed in the clangd exe.
     Without this script, it is impossible to automatically trigger this download and it introduces the risk that we do not update all the tooling to the latest version.

Fixes clangd#683

In this reapply, we quote both the command line and the arguments, such that both can contain spaces.
We also introduce the option useScriptAsExecutable, such that this is only enabled when the user wants it.
We also provide the default value as boolean instead of string
@HighCommander4
Copy link
Contributor

We also provide the default value as boolean instead of string

Ah, that's why the default value wasn't working!

@HighCommander4 HighCommander4 merged commit da913be into clangd:master Dec 22, 2024
1 check passed
@HighCommander4
Copy link
Contributor

HighCommander4 commented Dec 22, 2024

Created an unstable release including this change at https://github.com/clangd/vscode-clangd/releases/tag/snapshot_20241222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer possible to use cmd as clangd executable
2 participants