fix(complete): Include positionals in subcommands

Fixes #5139
clap-rs · Sep 25, 2023 · 017c258 · 017c258
1 parent 82c93ce
commit 017c258
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/clap_complete/src/dynamic/completer.rs b/clap_complete/src/dynamic/completer.rs
@@ -63,7 +63,7 @@ pub fn complete(
         if let Ok(value) = arg.to_value() {
             if let Some(next_cmd) = current_cmd.find_subcommand(value) {
                 current_cmd = next_cmd;
-                pos_index = 0;
+                pos_index = 1;
                 continue;
             }
         }

diff --git a/clap_complete/tests/testsuite/dynamic.rs b/clap_complete/tests/testsuite/dynamic.rs
@@ -113,7 +113,10 @@ fn suggest_subcommand_positional() {
 
     snapbox::assert_eq(
         "--help\tPrint help (see more with '--help')
--h\tPrint help (see more with '--help')",
+-h\tPrint help (see more with '--help')
+hello-world\tSay hello to the world
+hello-moon
+goodbye-world",
         complete!(cmd, "hello-world [TAB]"),
     );
 }