Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(parser): Check if args were present
In clap2, `ArgMatches.args` was public but hidden. We made it private in clap3, giving us more implementation flexibility but many people relied on it, like to short-circuit defaulting, providing their own `ArgRequiredElseHelp`, etc. The main problem was how to expose this - If we think of `ArgMatches` as a container (a DAG), should we have an `is_empty` and what all is included in that, like subcommands? - If we focus on only args, what term how do we refer to this to convey the right intent? In the end, I realized that this aligns most with our existing `is_present` check and reporting if args are present fits the best within the existing API. I looked into also exposing iterating over the args (`present_arg_ids`) but we have no way to expose the Id. The Id is currently private and if we made it public, it can't be used to access any arg because it can't implement `Key`. This supersedes #3265
- Loading branch information