Merge pull request #4896 from clubby789/bash-hint-other

completion: Respect `ValueHint::Other` in Bash
clap-rs · May 9, 2023 · fca1e03 · fca1e03
2 parents 0174326 + 2f97216
commit fca1e03
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/clap_complete/src/shells/bash.rs b/clap_complete/src/shells/bash.rs
@@ -206,6 +206,8 @@ fn vals_for(o: &Arg) -> String {
                 .collect::<Vec<_>>()
                 .join(" ")
         )
+    } else if o.get_value_hint() == ValueHint::Other {
+        String::from("\"${cur}\"")
     } else {
         String::from("$(compgen -f \"${cur}\")")
     }

diff --git a/clap_complete/tests/snapshots/value_hint.bash b/clap_complete/tests/snapshots/value_hint.bash
@@ -34,7 +34,7 @@ _my-app() {
                     return 0
                     ;;
                 --other)
-                    COMPREPLY=($(compgen -f "${cur}"))
+                    COMPREPLY=("${cur}")
                     return 0
                     ;;
                 --path)