[fish] Flags are not completed after first flag has been completed

[zx8]

Rust Version

• rustc 1.24.1 (d3ae9a9e0 2018-02-27)

Affected Version of clap

• v2.31.1

Expected Behavior Summary

$ rg --<TAB>
# list of completions
$ rg --no-follow --<TAB>
# list of completions

Actual Behavior Summary

$ rg --<TAB>
# works - list of completions
$ rg --no-follow --<TAB>
# broken; no completions

[zx8]

The issue here is the usage of the __fish_using_command function. Here's what's going on:

$ rg --no-follow --<TAB>
function __fish_using_command
    # cmd is set to array: ["rg", "--no-line-number"]
    set cmd (commandline -opc)
    # 'count $cmd' is 2, 'count $argv' is 1  
    if [ (count $cmd) -eq (count $argv) ]
        # etc.
        return 0
    end
    # no completions
    return 1
end

If you drop this function entirely (which I understand was introduced to fix subcommand completion; #687, /ping @wdv4758h), flag completions >1 work again, i.e.

complete -c rg -s N -l no-line-number -d 'Suppress line numbers.'

[wdv4758h]

this issue fix so fast, nice 👍

[kbknapp]

I'm putting out the new version in just a minute :)