Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: Fix completion of >1 options #1214

Merged
merged 1 commit into from
Mar 19, 2018
Merged

fish: Fix completion of >1 options #1214

merged 1 commit into from
Mar 19, 2018

Conversation

gechr
Copy link

@gechr gechr commented Mar 18, 2018

Fixes #1212 using upstream __fish_use_subcommand / __fish_seen_subcommand_from functions rather than creating our own custom one.

This is my first foray in to the world of Rust, so feel free to amend my changes as you see fit.


This change is Reviewable

@mention-bot
Copy link

@gechr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp
Copy link
Member

kbknapp commented Mar 19, 2018

Excellent, thanks! It works great! 👍

@kbknapp kbknapp merged commit b909132 into clap-rs:master Mar 19, 2018
@kbknapp kbknapp mentioned this pull request Mar 19, 2018
87 tasks
@gechr gechr deleted the gc-fix-fish-opt-complete branch March 19, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants