Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that env needs feature in dervie reference #3464

Closed
pksunkara opened this issue Feb 14, 2022 Discussed in #3463 · 2 comments · Fixed by #3536
Closed

Mention that env needs feature in dervie reference #3464

pksunkara opened this issue Feb 14, 2022 Discussed in #3463 · 2 comments · Fixed by #3536
Labels
A-docs Area: documentation, including docs.rs, readme, examples, etc...

Comments

@pksunkara
Copy link
Member

https://github.com/clap-rs/clap/blob/v3.0.14/examples/derive_ref/README.md#arg-attributes

From: #3463

@pksunkara pksunkara added the A-docs Area: documentation, including docs.rs, readme, examples, etc... label Feb 14, 2022
@epage
Copy link
Member

epage commented Feb 14, 2022

There is a cost to each feature flag we create (e.g. code complexity; bloating of documentation, making it harder to find relevant information).

I wonder if we are getting the desired value out of having an env feature flag and if we should deprecate it.

@pksunkara
Copy link
Member Author

I think we would probably need to decide how exactly we are going to make clap modular before deprecating this. We don't want to increase the churn by redoing this later.

pksunkara added a commit that referenced this issue Mar 5, 2022
@pksunkara pksunkara linked a pull request Mar 5, 2022 that will close this issue
epage added a commit that referenced this issue Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation, including docs.rs, readme, examples, etc...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants