Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Issue #1160 #1167

Merged
merged 2 commits into from
Feb 6, 2018
Merged

style: Issue #1160 #1167

merged 2 commits into from
Feb 6, 2018

Conversation

etopiei
Copy link
Contributor

@etopiei etopiei commented Feb 6, 2018 •
edited by kbknapp
Loading

Changed error message according to Issue #1160

This change is Reviewable

@mention-bot
Copy link

@etopiei, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp
Copy link
Member

kbknapp commented Feb 6, 2018

@etopiei thanks for knocking this out! I believe (but can't remember off the top of my head) there are a few tests which test against the old wording. Running cargo test should pop up the ones which fail. Could you change those locations in the tests as well?

@kbknapp kbknapp merged commit 32c6105 into clap-rs:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etopiei @mention-bot @kbknapp