-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(macros): add subcommand expr macro #1523
Conversation
Could you rebase onto the latest master (which is now at v3-beta). Thanks! |
@kbknapp dunzo, waiting to see if I have received the appveyor+travis blessing. |
@shua Sorry for the headache...there was some confusion due to my absence over the past few months... v3-master "just now" became master in prep for a beta release. This PR was autoclosed when the v3-master branch went away. This will need one final rebase onto master 😟 Again, apologies |
as a heads up, travis checks are failing for rust v1.33.0 with
(eg https://travis-ci.org/clap-rs/clap/jobs/604794320#L538 or https://travis-ci.org/clap-rs/clap/jobs/604736365#L535 ) Success and ✔️ tests pass for other versions tested though (beta/nightly/stable) |
@kbknapp ^ I suspect master would not pass travis-ci checks right now due to some transient toml dependency using an unstable feature. |
@shua Perhaps you can restrict |
I think we're going to just up the minimum supported Rust to 1.36 which should take care of it. See #1590 which should unblock this PR. |
Was using some hacks to use both the macros and subcommands with hyphens in their names (example based on a cli tool I use a lot: https://concourse-ci.org/setting-pipelines.html)
Added some parsing rules to allow alternative parsing of
expr
subcommand names similar to that used for(@arg ("non-ident-name"): --("non-ident-flag")
:and