setting: IgnoreErrors - Allow parsing despite missing option values #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolloch
force-pushed
the
feature/partial-parsing
branch
from
03b108a to
521183c
Compare
pksunkara
reviewed
May 18, 2021
|
Hi @pksunkara, thank you so much for getting back to me! I'll have time again to work on this during the weekend (a little bit on Saturday, more on Sunday, CEST time zone).Thank you for your patience :) |
kolloch
added a commit
to kolloch/clap
that referenced
this pull request
Jun 12, 2021
kolloch
force-pushed
the
feature/partial-parsing
branch
from
521183c to
dc35409
Compare
|
Hi @pksunkara, unfortunately, I haven't addressed the "safe-guard" comment yet because I am unclear about the meaning. I might have time later today but more probable tomorrow. I also rebased the PR, I hope that's appropriate. I put the new changes in an extra commit so you more easily review just the changes. |
|
Looks good. Can you please resolve conflicts? |
Implemented as AppSetting::Ignore errors as suggested by @CreepySkeleton in clap-rs#1880 (comment). This is not a complete implementation but it works already in surprisingly many situations. clap-rs#1880
kolloch
force-pushed
the
feature/partial-parsing
branch
from
dc35409 to
171dcbe
Compare
Sure :) Out of confusion I rebased on the master of my fork before. sigh |
pksunkara
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as AppSetting::Ignore errors as suggested by
@CreepySkeleton in
#1880 (comment).
This is not a complete implementation but it works already in
surprisingly many situations.
#1880