wip: Clean up lifetimes, whitespace at end of lines and folded multi line function definitions into one where suitable

[WildCryptoFox]

Quick in vim, cleaned up lifetimes for App Arg and SubCommand. Somewhere I broke something. 😉

DO NOT MERGE

---

That's me for the night. 💤

[kbknapp]

We'll need to a scrub (as best we can) to see how many code bases this affects. Since this is a breaking change for anyone returning an Arg or App from a function call.

Don't get me wrong, I'm ok with a breaking change for a huge ergonomic win, I just want to be as political about it as possible so as not to make too many people angry that APIs are changing unstably underneath them.

The harder to assess breaking change of this PR is when someone is using a 'static lifetime for any of the "settings" builder methods, and a non 'static lifetime for any of the others because Rust will complain that the non-static lifetime doesn't live long enough. I haven't checked this PR too deeply, but a potential way to solve this is saying all those "settings" lifetimes last at least as long as the Arg name (which must persist as long as the returned ArgMatches is alive.

Thoughts, comments?

[WildCryptoFox]

The lifetime for 'a as applied to it's fields already guarantees this. It is not saying that they must all have the same lifetime.

And yes, this would be a breaking change and can wait for the next major as it is a low priority.

[kbknapp]

Sounds good. The major feature I'd be willing to bump to a 2.x is automatic serialization into a Rust struct (a la docopt), so 2.x may be here sooner rather than later.

[WildCryptoFox]

@kbknapp Serialization as in #146? That issue is heavily neglected for discussion

[WildCryptoFox]

Closing in favor of #258. I'll include the code cleanup after CowStr.