feat(clap_complete): add native completion support for elvish #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Jun 21, 2024
If this isn't closing out the issue, what is left? |
I don't understand what you mean. Adding the related issue is for easier tracking :) |
The language used doesn't make this sound like the issue is fully resolved by this PR, so I was asking what is left. In fact, there are standardized terms for fully resolving an issue as Github has support for keywords to link PRs to issues (not just backlinks) and even auto-close issues. |
|
FYI this now has merge conflicts |
|
New set of conflicts to resolve |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #3919
Work in this PR