Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clap_complete): Add support for visible subcommand aliases #5549

Merged
merged 2 commits into from
Jul 17, 2024
Merged

feat(clap_complete): Add support for visible subcommand aliases #5549

merged 2 commits into from
Jul 17, 2024

Conversation

shannmu
Copy link
Contributor

@shannmu shannmu commented Jun 25, 2024 •
edited

related issue: #3951 (comment)

@shannmu shannmu marked this pull request as draft June 30, 2024 16:49
@shannmu
Copy link
Contributor Author

shannmu commented Jul 1, 2024

I implemented these traits for CompletionCandidate to minimize changes to other code, so it might be tricky. I will modify these tricky parts or document as much as possible.

@shannmu shannmu marked this pull request as ready for review July 6, 2024 06:45
@shannmu shannmu mentioned this pull request Jul 6, 2024
Closed
This was referenced Jul 17, 2024
Merged
Merged
@epage epage merged commit 4a8d680 into clap-rs:master Jul 17, 2024
21 of 22 checks passed
@epage epage mentioned this pull request Aug 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shannmu @epage