Issues 740,742,744,753,754 #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contributing sections
…esn't work when conflicts are also set Closes #753
…ics if there were no subcommands Closes #754
Flags, Opts, and Positionals now store their internals using compartmented Base, Valued, and Switched structs to keep the code duplication down and make it easier to maintain. Iniside the src/app/parser.rs there have been several changes to make reasoning about the code easier. Primarily moving related sections out of the large get_matches_with into their own functions.
… specific args vice command wide One can now use `Arg::allow_hyphen_values(true)` which will enable `--opt -val` style values only for the specific arg and not command wide. Closes #742
Failing value validators now produce messages like the following: error: Invalid value for '-j <val>': some message about the value Closes #744
|
@homu r+ |
|
📌 Commit cf06384 has been approved by |
|
☀️ Test successful - status |
2 tasks
|
BurntSushi/ripgrep#233 (comment) discusses some of the motivation for the design though it doesn't get into where this feature diverges from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.