Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the --version and --help messages #894

Merged
merged 2 commits into from
Mar 10, 2017

Conversation

porglezomp
Copy link
Contributor

Fixes #889

This currently doesn't support customizing them from YAML, so it still needs some work.

@coveralls
Copy link

coveralls commented Mar 10, 2017

Coverage Status

Coverage increased (+0.2%) to 91.792% when pulling 389c413 on porglezomp:feature/customize-version-help into cb5c9f7 on kbknapp:master.

@porglezomp
Copy link
Contributor Author

Nice, the YAML stuff was really easy to add.

@porglezomp porglezomp force-pushed the feature/customize-version-help branch from bcce5ce to c5dac3f Compare March 10, 2017 06:55
@coveralls
Copy link

coveralls commented Mar 10, 2017

Coverage Status

Coverage increased (+0.2%) to 91.803% when pulling c5dac3f on porglezomp:feature/customize-version-help into cb5c9f7 on kbknapp:master.

@coveralls
Copy link

coveralls commented Mar 10, 2017

Coverage Status

Coverage increased (+0.2%) to 91.803% when pulling c5dac3f on porglezomp:feature/customize-version-help into cb5c9f7 on kbknapp:master.

@kbknapp
Copy link
Member

kbknapp commented Mar 10, 2017

Looks great, thanks for knocking this out! I was a little worried about confusing people with help_message and them thinking it's analogous to App::about but then I saw your documentation 😄 This would be a super minor thing anyways so I'm fine with it. Plus there isn't really anything better, help_help invites potentially more confusion.

Thanks again! 👍 @homu r+

@homu
Copy link
Contributor

homu commented Mar 10, 2017

📌 Commit c5dac3f has been approved by kbknapp

homu added a commit that referenced this pull request Mar 10, 2017
…napp

Allow customizing the --version and --help messages

Fixes #889

This currently doesn't support customizing them from YAML, so it still needs some work.
@homu homu merged commit c5dac3f into clap-rs:master Mar 10, 2017
@homu
Copy link
Contributor

homu commented Mar 10, 2017

⚡ Test exempted - status

@kbknapp
Copy link
Member

kbknapp commented Mar 10, 2017

Once #893 merges, I'll put out a new version on crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants