fixes #3

clarketm · Apr 28, 2019 · 0ce7f83 · 0ce7f83
1 parent 5ea3dcc
commit 0ce7f83
Show file tree

Hide file tree

Showing 6 changed files with 44 additions and 23 deletions.
diff --git a/dist/super.es.js b/dist/super.es.js
@@ -1846,9 +1846,14 @@ var Heap = function () {
     key: "deleteMax",
     value: function deleteMax() {
       var _return = this._heap[0];
-      var _min = this._heap.pop();
-      if (this._heap.length > 1) this._heap[0] = _min;
-      this._percolateDown(0);
+
+      if (this._heap.length === 1) {
+        this._heap.pop();
+      } else {
+        this._heap[0] = this._heap.pop();
+        this._percolateDown(0);
+      }
+
       return _return;
     }
 

diff --git a/dist/super.js b/dist/super.js
@@ -1852,9 +1852,14 @@
       key: "deleteMax",
       value: function deleteMax() {
         var _return = this._heap[0];
-        var _min = this._heap.pop();
-        if (this._heap.length > 1) this._heap[0] = _min;
-        this._percolateDown(0);
+
+        if (this._heap.length === 1) {
+          this._heap.pop();
+        } else {
+          this._heap[0] = this._heap.pop();
+          this._percolateDown(0);
+        }
+
         return _return;
       }
 

diff --git a/dist/super.min.js b/dist/super.min.js
diff --git a/packages/Heap/lib/Heap.js b/packages/Heap/lib/Heap.js
@@ -174,9 +174,14 @@
       key: "deleteMax",
       value: function deleteMax() {
         var _return = this._heap[0];
-        var _min = this._heap.pop();
-        if (this._heap.length > 1) this._heap[0] = _min;
-        this._percolateDown(0);
+
+        if (this._heap.length === 1) {
+          this._heap.pop();
+        } else {
+          this._heap[0] = this._heap.pop();
+          this._percolateDown(0);
+        }
+
         return _return;
       }
 

diff --git a/packages/Heap/lib/Heap.min.js b/packages/Heap/lib/Heap.min.js
diff --git a/packages/Heap/src/lib/Heap.js b/packages/Heap/src/lib/Heap.js
@@ -158,9 +158,14 @@ class Heap {
    */
   deleteMax() {
     let _return = this._heap[0];
-    let _min = this._heap.pop();
-    if (this._heap.length > 1) this._heap[0] = _min;
-    this._percolateDown(0);
+
+    if (this._heap.length === 1) {
+      this._heap.pop();
+    } else {
+      this._heap[0] = this._heap.pop();
+      this._percolateDown(0);
+    }
+
     return _return;
   }