fix(ipv6): Use net.JoinHostPort instead of fmt.Sprintf #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation canceled.
|
|
Thanks for the contribution, @johannwagner, it would be great if we could connect to understand better how are you using (or evaluating) Kamaji in IPv6 environments. If the CI is green happy to get this merged. |
|
Of course, we can do this! Shoot me a mail at Good to hear! |
johannwagner
force-pushed
the
fix/ipv6-bugs
branch
from
35e6773 to
b1b2153
Compare
|
We also just confirmed, that creating an IPv6 only cluster is possible with this PR. |
prometherion
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into some issues regarding the handling of IPv6 addresses.
This PR rectifies those problems by utilizing net.JoinHostPort instead of fmt.Sprintf for joining IP addresses with ports.
If you have an IPv6 address, it adds braces, e.g.
[xxx], around the IP. Otherwise the result is an invalid IPv6 address.