Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: making default datastore optional #597

Merged

Conversation

prometherion
Copy link
Member

@prometherion prometherion commented Oct 7, 2024

@bsctl this change is required to support the DataStore Scheduler enterprise addon we aim to release.

After this change, Kamaji can be started with no --datastore field, forcing a Datastore assignment from user or addons.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for kamaji-documentation ready!

Name Link
🔨 Latest commit fd3185e
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/67224c4d3cb5dd0009682ebf
😎 Deploy Preview https://deploy-preview-597--kamaji-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prometherion prometherion force-pushed the feat/optional-default-datastore branch 2 times, most recently from fdde0a7 to 079f604 Compare October 7, 2024 17:19
Copy link
Member

@bsctl bsctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prometherion what about to have default datastore disabled by default?

@prometherion
Copy link
Member Author

That would be very bad: even tho we released the v1.0.0 as stable and we have safe defaults for beginners, I would avoid providing a stumped Kamaji with no Datastore.

I'm expecting to get an HCP architecture just with a single command, without the complexity of installing the etcd with a different command, etc.

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@prometherion prometherion force-pushed the feat/optional-default-datastore branch from 079f604 to fd3185e Compare October 30, 2024 15:10
@prometherion
Copy link
Member Author

Just tested, when creating a TenantControlPlane with missing DataStore the following logs are expected.

2024-10-30T15:07:44Z    INFO    the Tenant Control Plane doesn't have a DataStore assigned, and Kamaji is running with no default DataStore fallback    {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "TenantControlPlane": {"name":"k8s-130","namespace":"kamaji-system"}, "namespace": "kamaji-system", "name": "k8s-130", "reconcileID": "20318484-cbb6-49e4-b515-2d14d9a87a37"}

If you restart the Kamaji Operator with the --datastore value, all the Tenant Control Plane instances with no DataStore will be set up with that value.

If CI is green, happy to get this merged.

@bsctl bsctl self-requested a review October 30, 2024 16:34
@prometherion prometherion merged commit 0c01110 into clastix:master Oct 30, 2024
10 checks passed
@prometherion prometherion deleted the feat/optional-default-datastore branch October 30, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants