Merge pull request #1543 from clauderic/patch-1

fix: auto-scroll bug with multiple containers
clauderic · Nov 23, 2024 · 3c4f627 · 3c4f627
2 parents baad391 + bcaf7c4
commit 3c4f627
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/.changeset/thin-walls-remain.md b/.changeset/thin-walls-remain.md
@@ -0,0 +1,5 @@
+---
+'@dnd-kit/core': patch
+---
+
+Fix a bug with auto-scroller continuing to observe stale elements, causing them to be considered as scrollable.
diff --git a/packages/core/src/hooks/utilities/useRects.ts b/packages/core/src/hooks/utilities/useRects.ts
@@ -36,17 +36,10 @@ export function useRects(
 
   const resizeObserver = useResizeObserver({callback: measureRects});
 
-  if (elements.length > 0 && rects === defaultValue) {
-    measureRects();
-  }
-
   useIsomorphicLayoutEffect(() => {
-    if (elements.length) {
-      elements.forEach((element) => resizeObserver?.observe(element));
-    } else {
-      resizeObserver?.disconnect();
-      measureRects();
-    }
+    resizeObserver?.disconnect();
+    measureRects();
+    elements.forEach((element) => resizeObserver?.observe(element));
   }, [elements]);
 
   return rects;