Only prevent default/propagation if not idle

clauderic · Jan 26, 2025 · e6a8e01 · e6a8e01
1 parent 3312dcf
commit e6a8e01
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/fix-interactive-elements.md b/.changeset/fix-interactive-elements.md
@@ -0,0 +1,5 @@
+---
+'@dnd-kit/dom': patch
+---
+
+Fix a bug with `event.preventDefault()` and `event.stopPropagation()` being called on pointer up even if there was no drag operation in progress, which would prevent interactive elements such as buttons from being clicked.
diff --git a/packages/dom/src/core/sensors/pointer/PointerSensor.ts b/packages/dom/src/core/sensors/pointer/PointerSensor.ts
@@ -234,14 +234,14 @@ export class PointerSensor extends Sensor<
   }
 
   private handlePointerUp(event: PointerEvent) {
-    // Prevent the default behaviour of the event
-    event.preventDefault();
-    event.stopPropagation();
-
     // End the drag and drop operation
     const {status} = this.manager.dragOperation;
 
     if (!status.idle) {
+      // Prevent the default behaviour of the event
+      event.preventDefault();
+      event.stopPropagation();
+
       const canceled = !status.initialized;
       this.manager.actions.stop({canceled});
     }