Allow consumers to determine when to perform layout animations and when to measure nodes #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fddb961 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +1.8 kB (+2%) Total Size: 82.7 kB
ℹ️ View Unchanged
|
clauderic
changed the title
clauderic
force-pushed
the
should-perform-layout-animation
branch
2 times, most recently
from
f4f42c4
to
243dd58
Compare
clauderic
force-pushed
the
should-perform-layout-animation
branch
from
243dd58
to
432b704
Compare
This strategy allows consumers to measure nodes before dragging instead of right after dragging has begun.
clauderic
force-pushed
the
should-perform-layout-animation
branch
from
2667289
to
b7c2780
Compare
clauderic
force-pushed
the
should-perform-layout-animation
branch
from
a62c749
to
fddb961
Compare
Merged
|
Can this be added to the docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows consumers to customize or override the internal heuristics for determining whether derived transformations should be applied to allow a sortable node to perform layout animations.
By default, layout animations via derived transforms happen when sorting is cancelled or when new elements are added / removed within the list during sorting.
Letting consumers override this option opens up a lot of new possibilities for consumers, such as easily animating adding / deleting items (see #108) or only animating items to their new positions on drop rather than while dragging:
Kapture.2021-03-21.at.19.31.04.mp4
Kapture.2021-03-22.at.10.31.28.mp4
Kapture.2021-03-23.at.21.56.00.mp4