Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collision detection issues #337

Merged
merged 7 commits into from
Jun 22, 2021

Conversation

clauderic
Copy link
Owner

@clauderic clauderic commented Jun 21, 2021

  • Batch React updates in non-synthetic event handlers
  • Defer measurement of droppable node rects until second render after dragging
  • Use DragOverlay's width and height in collision rect (if it is used)

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2021

🦋 Changeset detected

Latest commit: 9648b5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@dnd-kit/core Major
@dnd-kit/modifiers Major
@dnd-kit/sortable Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2021

Size Change: +737 B (+1%)

Total Size: 59.3 kB

Filename Size Change
packages/core/dist/core.cjs.development.js 16 kB +319 B (+2%)
packages/core/dist/core.cjs.production.min.js 10.1 kB +117 B (+1%)
packages/core/dist/core.esm.js 15.8 kB +301 B (+2%)
ℹ️ View Unchanged
Filename Size
packages/accessibility/dist/accessibility.cjs.development.js 640 B
packages/accessibility/dist/accessibility.cjs.production.min.js 486 B
packages/accessibility/dist/accessibility.esm.js 503 B
packages/accessibility/dist/index.js 148 B
packages/core/dist/index.js 141 B
packages/modifiers/dist/index.js 144 B
packages/modifiers/dist/modifiers.cjs.development.js 642 B
packages/modifiers/dist/modifiers.cjs.production.min.js 471 B
packages/modifiers/dist/modifiers.esm.js 561 B
packages/sortable/dist/index.js 144 B
packages/sortable/dist/sortable.cjs.development.js 3.84 kB
packages/sortable/dist/sortable.cjs.production.min.js 2.52 kB
packages/sortable/dist/sortable.esm.js 3.73 kB
packages/utilities/dist/index.js 144 B
packages/utilities/dist/utilities.cjs.development.js 1.34 kB
packages/utilities/dist/utilities.cjs.production.min.js 802 B
packages/utilities/dist/utilities.esm.js 1.25 kB

compressed-size-action

@clauderic clauderic force-pushed the fix-collision-detection-race-conditions branch from d245313 to b5d7813 Compare June 22, 2021 16:49
@clauderic clauderic force-pushed the fix-collision-detection-race-conditions branch from aebfd45 to e053156 Compare June 22, 2021 21:17
@clauderic clauderic marked this pull request as ready for review June 22, 2021 21:28
@clauderic clauderic merged commit 05d6a78 into master Jun 22, 2021
@clauderic clauderic deleted the fix-collision-detection-race-conditions branch June 22, 2021 21:52
@github-actions github-actions bot mentioned this pull request Jun 22, 2021
@clauderic clauderic changed the title Fix collision detection race conditions Fix collision detection issues Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant