-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for tolerance in DistanceConstraint #399
Support for tolerance in DistanceConstraint #399
Conversation
🦋 Changeset detectedLatest commit: d812ec3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Would you mind adding stories and integration tests for minimum distance y and tolerance x?
I'm also a bit unclear as to how this should work if you provided a tolerance that was smaller than the distance or a tolerance that was in a different axis than the distance 🤔
@clauderic Thank you for the reply!
Done!
The way it's working right now is as soon as you exceed {
distance: {x: 10},
tolerance: {x: 5},
} won't make sense since you can never meet the Tolerance in different axis than the distance is exactly how we're using it right now in our project, and that is described here. Please let me know if anything is unclear! |
Sounds good 👍 Could you add a changeset to your PR or give me access to your fork so I can do it for you? |
No description provided.