Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compute collision against DragOverlay child bounding rect #408

Merged
merged 3 commits into from
Aug 18, 2021
Merged

fix: compute collision against DragOverlay child bounding rect #408

merged 3 commits into from
Aug 18, 2021

Commits on Aug 10, 2021

  1. fix: compute collision against DragOverlay child bounding rect

    @wmain
    wmain committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    89a5b63 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Fix assumptions around usage of drag source rect instead of drag overlay 

    When dragging without a drag overlay, we need to compute a delta between the draggable node's initial position and new position if it is reparented.

This logic isn't relevant when using the DragOverlay. It was working before because we were only using the width and height of the drag overlay in the collision rect
    Clauderic Demers committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    fd2eb9a View commit details
    Browse the repository at this point in the history

  2. Add changeset

    @clauderic
    clauderic authored Aug 18, 2021
    Configuration menu
    Copy the full SHA
    b253d36 View commit details
    Browse the repository at this point in the history