fix: pass willRecomputeLayouts to useClientRect call for overlayNodeRect #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the additional investigation done for #408 @clauderic. It looks like removing
willRecomputeLayouts
from theuseClientRect
call ofoverlayNodeRect
rebreaks our case, however. Reading over the methodology/cause of the changes you made, I'm not sure why this argument was removed, but adding it back in seems to fix things. It seems to me that recomputing the layout rect of the measurable child is required as the overlay moves.