-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observe resizes of droppable containers while dragging #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6a9cb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +1.32 kB (+2%) Total Size: 68.9 kB
ℹ️ View Unchanged
|
Also renamed `recomputeLayouts` to `recomputeRects` and `willRecomputeLayouts` to `willRecomputeRects`
While sorting, it's possible for the size of droppable elements to change. We add a resize observer to keep track of size changes and schedule recomputation of the bounding rectangles of the droppable elements when resize events occur. The `resizeObserverConfig` param can be used to disable or configure the resize observer.
clauderic
force-pushed
the
droppable-resize-observer
branch
from
January 7, 2022 02:05
3fba297
to
823d4d2
Compare
clauderic
force-pushed
the
droppable-resize-observer
branch
4 times, most recently
from
January 7, 2022 03:37
f9d9a2f
to
9ae168c
Compare
clauderic
force-pushed
the
droppable-resize-observer
branch
from
January 7, 2022 03:50
9ae168c
to
b6a9cb8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow partial recomputation of droppable rects, and adds a resize observer to droppable elements to observe changes in the size of droppable elements while dragging