Refactor useDndMonitor() to dispatch events synchronously
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf30718 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clauderic
force-pushed
the
dnd-monitor-refactor
branch
3 times, most recently
from
f0e32fa
to
3c58d30
Compare
clauderic
force-pushed
the
dnd-monitor-refactor
branch
from
3c58d30
to
bf30718
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
useDndMonitor()hook has been refactored to be synchronously invoked at the same time as the events dispatched by<DndContext>(such asonDragStart,onDragOver,onDragEnd).The new refactor uses the subscribe/notify pattern and no longer causes re-renders in consuming components of
useDndMonitor()when events are dispatched.