Fix a regression with the KeyboardSensor's scrolling logic #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression introduced in 750d726 with the
KeyboardSensor
's scrolling logic.When the KeyboardSensor can scroll to the new coordinates but there is a delta on the opposite axis (for example, if we can scroll on the
y
axis but there is a delta on thex
axis) theKeyboardSensor
would scroll to themaxScroll
orminScroll
coordinates instead of the new scroll coordinates.