fix page action issues #37 (comment)

- FF56: the page action was getting displayed after a server-initiated redirection from HTTP to HTTPS, even when the site was excluded (which led to the user being offered the opportunity to exclude again)
- the same was happening with sites that use STS, but also in recent versions of FF

src/bg/runtime.js

@@ -35,8 +35,10 @@ runtime.onMessage.addListener(async (msg, sender, sendResponse) => {
 			if (tabsData[tabId]) delete tabsData[tabId].loading;
 			await sAPI.loading;
 			if (
-				processed.has(msg.host) && msg.protocol === 'https:' ||
+				processed.has(msg.host) && msg.protocol === 'https:' &&
+				!isWhitelisted(msg.host) && !isIgnored(msg.host) ||
 				isWhitelisted(msg.host) && msg.protocol === 'http:'
 			) return pageAction.show(tabId);
+			else return pageAction.hide(tabId);
 	}
 });

src/bg/webRequest.js

@@ -136,18 +136,6 @@ webReq.onBeforeRedirect.addListener(d => {
 	}
 }, sfilter);
 
-webReq.onBeforeRedirect.addListener(d => {
-/*	prevent showing the page action when something (anything) redirects a whitelisted or
-	ignored request from http to https
-	IMPORTANT: the documentation for this event says it is fired only on server-initiated
-	redirections, but it is wrong. Even this very extension fires this when upgrading */
-	const target = new URL(d.redirectUrl);
-	if (
-		target.protocol === 'https:' &&
-		( isWhitelisted(target.hostname) || isIgnored(target.hostname) )
-	) processed.delete(target.hostname);
-}, filter);
-
 webReq.onResponseStarted.addListener(d => {
 	// required only as part of the mechanism that detects non-standard redirections to http
 	const url = new URL(d.url);