Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support overriding default prefix, #, in Map keys - SetGlobalKeyMapP… #107

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Support overriding default prefix, #, in Map keys - SetGlobalKeyMapP… #107

merged 3 commits into from
Nov 28, 2022

Conversation

gdbc
Copy link
Contributor

@gdbc gdbc commented Nov 22, 2022

…refix().

@clbanning
Copy link
Owner

clbanning commented Nov 23, 2022 •
edited
Loading

Please look at line 47 of leafnode.go.
Please look at lines 90 & 93 of updatevalues_test.go.

Also add "SetGlobalKeyMapPrefix("#")" at end of your test function, TestSetGlobalKeyMapPrefix().

@gdbc
Copy link
Contributor Author

gdbc commented Nov 23, 2022 •
edited
Loading

Thanks those have been refactored!

@clbanning clbanning merged commit 9fb13b0 into clbanning:master Nov 28, 2022
@tim-mwangi tim-mwangi mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdbc @clbanning