Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider adding ordered list of channel dataset names to attributes #10

Open
trautmane opened this issue Feb 16, 2023 · 2 comments
Open

consider adding ordered list of channel dataset names to attributes #10

trautmane opened this issue Feb 16, 2023 · 2 comments

Comments

@trautmane
Copy link

I think it would be useful to add the ordered channel names derived here to a separate attribute so that you can always identify channel order with certainty. The current convention of AI<channel number> with a limit of 5 channels works, but I think adding an explicitly ordered list is more future-proof.

Just a thought ...
@clbarnes
Copy link
Owner

clbarnes commented Feb 16, 2023 •
edited
Loading

Agreed, this would make for a good extra attribute in the same vein as the ISO dates and the named enum variants. So long as hdf5 is fine storing an array of strings of variable length, which I think it is. As this is a derived attribute rather than a normative one we could also comfortably strip or pad the original name with null bytes. Something like ChannelNames?

clbarnes added a commit that referenced this issue Feb 16, 2023
@clbarnes
Store header and footer as datasets not attributes
6f912da 
This fixes a problem with very long footers caused by padded image
channels; see #9.

Also stores the names of present channels as "AINames", see #10
@clbarnes
Copy link
Owner

Fixed in 6f912da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trautmane @clbarnes