DEPR: remove order kw from .factorize(), xref pandas-dev#6930

xref pandas-dev#6930

Author: Jeff Reback <jeff@reback.net>

Closes pandas-dev#12274 from jreback/order and squashes the following commits:

7584397 [Jeff Reback] DEPR: remove order kw from .factorize(), xref pandas-dev#6930

doc/source/whatsnew/v0.18.0.txt

@@ -788,6 +788,7 @@ Removal of prior version deprecations/changes
 - Removal of the ``read_frame`` and ``frame_query`` (both aliases for ``pd.read_sql``)
   and ``write_frame`` (alias of ``to_sql``) functions in the ``pd.io.sql`` namespace,
   deprecated since 0.14.0 (:issue:`6292`).
+- Removal of the ``order`` keyword from ``.factorize()`` (:issue:`6930`)
 
 .. _whatsnew_0180.performance:
 

pandas/core/algorithms.py

@@ -163,7 +163,6 @@ def factorize(values, sort=False, order=None, na_sentinel=-1, size_hint=None):
         Sequence
     sort : boolean, default False
         Sort by values
-    order : deprecated
     na_sentinel : int, default -1
         Value to mark "not found"
     size_hint : hint to the hashtable sizer
@@ -178,11 +177,6 @@ def factorize(values, sort=False, order=None, na_sentinel=-1, size_hint=None):
     note: an array of Periods will ignore sort as it returns an always sorted
     PeriodIndex
     """
-    if order is not None:
-        msg = "order is deprecated. See " \
-              "https://github.com/pydata/pandas/issues/6926"
-        warn(msg, FutureWarning, stacklevel=2)
-
     from pandas import Index, Series, DatetimeIndex
 
     vals = np.asarray(values)

pandas/tests/test_algos.py

@@ -53,12 +53,6 @@ def test_strings(self):
 class TestFactorize(tm.TestCase):
     _multiprocess_can_split_ = True
 
-    def test_warn(self):
-
-        s = Series([1, 2, 3])
-        with tm.assert_produces_warning(FutureWarning):
-            algos.factorize(s, order='A')
-
     def test_basic(self):
 
         labels, uniques = algos.factorize(['a', 'b', 'b', 'a', 'a', 'c', 'c',