Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate job for testing Docker build #580

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add separate job for testing Docker build #580

merged 1 commit into from
Jun 10, 2024

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented May 30, 2024

No description provided.

@lumaxis lumaxis force-pushed the actions-docker-build-job branch from d98f7c6 to 5926c39 Compare May 30, 2024 14:31
@lumaxis lumaxis marked this pull request as ready for review May 30, 2024 14:32
@lumaxis lumaxis requested a review from elrayle May 30, 2024 14:33
elrayle
elrayle approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these consistent across repos! Much easier to maintain that way.

@elrayle elrayle mentioned this pull request Jun 5, 2024
Merged
@elrayle
Copy link
Collaborator

elrayle commented Jun 5, 2024

NOTE: test doesn't run because it is being replaced by Run Docker build and tests. The branch settings will need to be updated when this is merged to require that action instead. Test that the change works in the service repo before merging this PR.

Related Work:

@elrayle elrayle mentioned this pull request Jun 5, 2024
Merged
@lumaxis lumaxis merged commit 3411b76 into master Jun 10, 2024
2 checks passed
@lumaxis lumaxis deleted the actions-docker-build-job branch June 10, 2024 15:17
elrayle pushed a commit that referenced this pull request Aug 12, 2024
@lumaxis @elrayle
Merge pull request #580 from clearlydefined/actions-docker-build-job
251cc60 
Add separate job for testing Docker build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elrayle elrayle elrayle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumaxis @elrayle