Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new traversal policy #598

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

qtomlinson
Copy link
Collaborator

The "always" traversal policy behaves as follows:

  • if the tool result (e.g. licensee) for a specific component exist, the component will be refetched and the tool will be rerun.
  • if the tool result for a specific component is missing, using the "always" policy to harvest leads to a "Unreachable for reprocessing" status and the tool being skipped.

The "always" traversal policy is basically a rerun for all the previously ran tools. It is somewhat cumbersome in the case to retrigger harvest, especially for integration tests.

The proposed new policy make re-harvest simpler:

  • When the tool result for a component is available, the tool will be rerun and tool result updated, similar to the "always" policy.
  • When the tool result for a component is not available, the component will be fetched and the tool will be run. In summary, this "reharvestAlways" policy is to rerun the harvest tools if results exist and run the harvest tools if results are missing.

The "always" traversal policy behaves as follows:
- if the tool result (e.g. licensee) for a specific component exist, the component will be refetched and the tool will be rerun.
- if the tool result for a specific component is missing, using the "always" policy leads to a "Unreachable for reprocessing" status and the tool being skipped.

The "always" traversal policy is basically a rerun for all the previously ran tools.  It is somewhat cumbersome in the case to retriger harvest, especially for integration tests.

The proposed new policy make reharvest simpler:
- When the tool result for a component is available, the tool will be rerun and tool result updated, similar to the "always" policy.
- When the tool result for a component is not available, the component will be fetched and the tool will be run.
In summary, this "reharvestAlways" policy is to rerun the harvest tools if results exist and run the harvest tools if results are missing.
@qtomlinson qtomlinson merged commit f0fb76a into clearlydefined:master Sep 27, 2024
2 checks passed
@qtomlinson qtomlinson deleted the qt/add_policy branch September 27, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants