Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fetch file to centralize default headers #620

Merged
merged 16 commits into from
Nov 5, 2024
Merged

Update fetch file to centralize default headers #620

merged 16 commits into from
Nov 5, 2024

Conversation

yashkohli88
Copy link
Contributor

Description:

This pull request focuses on refactoring the code to centralize the declaration of default headers in a single fetch.js file, updating all fetch functions in various package managers across the project to use the centralized user-agent header, and adding tests to validate these changes. Below are the tasks accomplished:

Checklist:

  • Refactored code to centralize default headers in fetch.js.
  • Updated all fetch functions to use the centralized default headers.
  • Added tests to validate the changes.
  • Ran all existing and new tests to ensure correctness.

This PR is related to issue - #619

yashkohli88 and others added 13 commits September 24, 2024 11:23
@yashkohli88
Added ClearlyDefined as User-Agent in default header
a6177c5
@yashkohli88
Updated default header in axios global config
5f68863
@yashkohli88
Freezed the defaultHeader object and exported it to maintain consiste…
be3b109 
…ncy throughout
@yashkohli88
Removed user-agent header from requests explicitly stated
0dee013
@yashkohli88
Updated testcases to check for user-agent header in requests
62b0626
@yashkohli88
Merge branch 'master' into yk/add-default-headers-centrally
a3ad449
@yashkohli88
Replace user-agent header with defaultHeader declared globally
f27aaac
@yashkohli88
Updated testcases with defaultHeader declared globally
62b2b45
@yashkohli88
Fix Formatting
ae5e87d
@yashkohli88
Removed Packagist testcase
45fba51
@yashkohli88
Merge branch 'master' into yk/add-default-headers-centrally
17a52ef
@yashkohli88
Replace user-agent with defaultHeader
b900709
@yashkohli88
Merge pull request #5 from clearlydefined/master
96293ca 
Merge branch 'master' into yk/add-default-headers-centrally
qtomlinson
qtomlinson reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@qtomlinson qtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

test/unit/lib/fetchTests.js Outdated Show resolved Hide resolved
test/unit/providers/fetch/mavenBasedFetchTests.js Outdated Show resolved Hide resolved
ljones140
ljones140 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ljones140 ljones140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
nice improvement to make sure we have consistent headers

@yashkohli88 yashkohli88 marked this pull request as ready for review November 3, 2024 05:05
@qtomlinson qtomlinson merged commit 59e652b into clearlydefined:master Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qtomlinson qtomlinson qtomlinson left review comments

@ljones140 ljones140 ljones140 approved these changes

@RomanIakovlev RomanIakovlev Awaiting requested review from RomanIakovlev

@elrayle elrayle Awaiting requested review from elrayle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashkohli88 @ljones140 @qtomlinson