Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1 #129

Merged
merged 109 commits into from
Oct 13, 2023
Merged

1.1 #129

merged 109 commits into from
Oct 13, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Nov 20, 2022

workerB

cleder and others added 20 commits September 29, 2022 09:07
Merge pull request #116 from cleder/develop
updates:
- [github.com/regebro/pyroma: 3.2 → 4.0](regebro/pyroma@3.2...4.0)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/psf/black: 22.8.0 → 22.10.0](psf/black@22.8.0...22.10.0)
- [github.com/pre-commit/mirrors-mypy: v0.981 → v0.982](pre-commit/mirrors-mypy@v0.981...v0.982)
[pre-commit.ci] pre-commit autoupdate
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.5.0 to 3.5.1.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3.5.0...v3.5.1)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…/setup-node-3.5.1

Bump actions/setup-node from 3.5.0 to 3.5.1
updates:
- [github.com/python-jsonschema/check-jsonschema: 0.18.3 → 0.18.4](python-jsonschema/check-jsonschema@0.18.3...0.18.4)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/hakancelikdev/unimport: 0.12.1 → 0dc8d609eb670eeb3335958acddcb6059cc4b8dd](hakancelikdev/unimport@0.12.1...0dc8d60)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/hakancelikdev/unimport: 0dc8d609eb670eeb3335958acddcb6059cc4b8dd → a56235171fc28dff6a879c377bb7392679552671](hakancelikdev/unimport@0dc8d60...a562351)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/hakancelikdev/unimport: a56235171fc28dff6a879c377bb7392679552671 → 004b5dd0c8112330275beb52c4ccfce016a4b945](hakancelikdev/unimport@a562351...004b5dd)
- [github.com/pre-commit/mirrors-mypy: v0.982 → v0.990](pre-commit/mirrors-mypy@v0.982...v0.990)
- [github.com/python-jsonschema/check-jsonschema: 0.18.4 → 0.19.1](python-jsonschema/check-jsonschema@0.18.4...0.19.1)
[pre-commit.ci] pre-commit autoupdate
@what-the-diff
Copy link

what-the-diff bot commented Nov 20, 2022

  • 1 (unreleased)

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 20, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 1.25 ⭐ 1.25 ⭐ 0.00
Method Length 35.31 ⭐ 35.28 ⭐ -0.03 👍
Working memory 5.49 ⭐ 5.49 ⭐ 0.00
Quality 85.01% 85.02% 0.01% 👍
Other metrics Before After Change
Lines 1574 1579 5
Changed files Quality Before Quality After Quality Change
setup.py 86.62% ⭐ 86.62% ⭐ 0.00%
pygeoif/__init__.py 83.69% ⭐ 83.69% ⭐ 0.00%
pygeoif/exceptions.py 98.33% ⭐ 98.33% ⭐ 0.00%
pygeoif/factories.py 77.34% ⭐ 77.40% ⭐ 0.06% 👍
pygeoif/feature.py 91.41% ⭐ 91.41% ⭐ 0.00%
pygeoif/functions.py 79.33% ⭐ 79.33% ⭐ 0.00%
pygeoif/geometry.py 90.49% ⭐ 90.48% ⭐ -0.01% 👎
pygeoif/types.py 56.94% 🙂 56.94% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pygeoif/factories.py _shell_holes_from_wkt_coords 2 ⭐ 75 🙂 10 😞 70.60% 🙂 Extract out complex expressions
pygeoif/factories.py from_wkt 2 ⭐ 122 😞 6 ⭐ 73.22% 🙂 Try splitting into smaller methods
pygeoif/factories.py _multiline_from_wkt_coordinates 0 ⭐ 48 ⭐ 11 😞 74.91% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fc19141) 100.00% compared to head (db0f50f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #129   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         2107      2134   +27     
=========================================
+ Hits          2107      2134   +27     
Impacted Files Coverage Δ
pygeoif/__init__.py 100.00% <ø> (ø)
pygeoif/exceptions.py 100.00% <ø> (ø)
pygeoif/feature.py 100.00% <ø> (ø)
pygeoif/geometry.py 100.00% <ø> (ø)
pygeoif/types.py 100.00% <ø> (ø)
tests/test_base.py 100.00% <ø> (ø)
tests/test_bounds.py 100.00% <ø> (ø)
tests/test_factories.py 100.00% <ø> (ø)
tests/test_feature.py 100.00% <ø> (ø)
tests/test_functions.py 100.00% <ø> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost
Copy link

ghost commented Nov 20, 2022

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cleder cleder marked this pull request as draft November 20, 2022 14:06
pre-commit-ci bot and others added 3 commits November 21, 2022 16:44
updates:
- [github.com/python-jsonschema/check-jsonschema: 0.19.1 → 0.19.2](python-jsonschema/check-jsonschema@0.19.1...0.19.2)
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci bot and others added 28 commits July 24, 2023 16:58
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.278 → v0.0.280](astral-sh/ruff-pre-commit@v0.0.278...v0.0.280)
[pre-commit.ci] pre-commit autoupdate
updates:
- https://github.com/ikamensh/flynt/: 1.0.0 → 1.0.1
- [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.280 → v0.0.282](astral-sh/ruff-pre-commit@v0.0.280...v0.0.282)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.282 → v0.0.286](astral-sh/ruff-pre-commit@v0.0.282...v0.0.286)
- [github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.1](pre-commit/mirrors-mypy@v1.4.1...v1.5.1)
- [github.com/python-jsonschema/check-jsonschema: 0.23.3 → 0.26.3](python-jsonschema/check-jsonschema@0.23.3...0.26.3)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.286 → v0.0.287](astral-sh/ruff-pre-commit@v0.0.286...v0.0.287)
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
[pre-commit.ci] pre-commit autoupdate
…/checkout-4

Bump actions/checkout from 3 to 4
updates:
- [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1)
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…/codecov-action-4

Bump codecov/codecov-action from 3 to 4
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/astral-sh/ruff-pre-commit: v0.0.287 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.287...v0.0.292)
- [github.com/python-jsonschema/check-jsonschema: 0.26.3 → 0.27.0](python-jsonschema/check-jsonschema@0.26.3...0.27.0)
[pre-commit.ci] pre-commit autoupdate
@cleder cleder marked this pull request as ready for review October 13, 2023 15:56
@cleder cleder merged commit be7fecf into main Oct 13, 2023
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant