-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.5.1 #264
Version 1.5.1 #264
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.3 → v0.4.4](astral-sh/ruff-pre-commit@v0.4.3...v0.4.4) - [github.com/abravalheri/validate-pyproject: v0.16 → v0.17](abravalheri/validate-pyproject@v0.16...v0.17) - [github.com/python-jsonschema/check-jsonschema: 0.28.2 → 0.28.3](python-jsonschema/check-jsonschema@0.28.2...0.28.3)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/abravalheri/validate-pyproject: v0.17 → v0.18](abravalheri/validate-pyproject@v0.17...v0.18)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.4 → v0.4.5](astral-sh/ruff-pre-commit@v0.4.4...v0.4.5) - [github.com/python-jsonschema/check-jsonschema: 0.28.3 → 0.28.4](python-jsonschema/check-jsonschema@0.28.3...0.28.4)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.5 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.5...v0.4.7)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.7 → v0.4.8](astral-sh/ruff-pre-commit@v0.4.7...v0.4.8)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9) - [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0) - [github.com/python-jsonschema/check-jsonschema: 0.28.4 → 0.28.5](python-jsonschema/check-jsonschema@0.28.4...0.28.5)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10) - [github.com/python-jsonschema/check-jsonschema: 0.28.5 → 0.28.6](python-jsonschema/check-jsonschema@0.28.5...0.28.6)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.10 → v0.5.0](astral-sh/ruff-pre-commit@v0.4.10...v0.5.0) - [github.com/pre-commit/mirrors-mypy: v1.10.0 → v1.10.1](pre-commit/mirrors-mypy@v1.10.0...v1.10.1)
for more information, see https://pre-commit.ci
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.5.1](astral-sh/ruff-pre-commit@v0.5.0...v0.5.1)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.1 → v0.5.2](astral-sh/ruff-pre-commit@v0.5.1...v0.5.2) - [github.com/python-jsonschema/check-jsonschema: 0.28.6 → 0.29.0](python-jsonschema/check-jsonschema@0.28.6...0.29.0)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.2 → v0.5.4](astral-sh/ruff-pre-commit@v0.5.2...v0.5.4) - [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.0](pre-commit/mirrors-mypy@v1.10.1...v1.11.0)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.4 → v0.5.5](astral-sh/ruff-pre-commit@v0.5.4...v0.5.5) - [github.com/python-jsonschema/check-jsonschema: 0.29.0 → 0.29.1](python-jsonschema/check-jsonschema@0.29.0...0.29.1)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0) - [github.com/astral-sh/ruff-pre-commit: v0.5.5 → v0.5.6](astral-sh/ruff-pre-commit@v0.5.5...v0.5.6) - [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1) - [github.com/pre-commit/mirrors-mypy: v1.11.0 → v1.11.1](pre-commit/mirrors-mypy@v1.11.0...v1.11.1)
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.6 → v0.5.7](astral-sh/ruff-pre-commit@v0.5.6...v0.5.7)
Changed Files
|
Reviewer's Guide by SourceryThis PR updates the package to version 1.5.1, focusing on code quality improvements, dependency updates, and CI/CD pipeline enhancements. The changes include updates to Python version support, linting configurations, and improvements to WKT (Well-Known Text) handling for geometric collections. Class diagram for updated WKT handlingclassDiagram
class Factories {
+split_wkt_components(wkt: str) List~str~
+_multigeometry_from_wkt_coordinates(coordinates: str) GeometryCollection
}
class GeometryCollection {
+_prepare_hull() Iterable~Point2D~
}
class MultiLineString {
+_prepare_hull() Iterable~Point2D~
}
class MultiPolygon {
+_prepare_hull() Iterable~Point2D~
}
Factories --> GeometryCollection
Factories --> MultiLineString
Factories --> MultiPolygon
note for Factories "New method split_wkt_components added"
note for GeometryCollection "Updated _prepare_hull method"
note for MultiLineString "Updated _prepare_hull method"
note for MultiPolygon "Updated _prepare_hull method"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hello @cleder! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-12-05 20:29:10 UTC |
PR Summary
|
Preparing review... |
1 similar comment
Preparing review... |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cleder - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -1085,9 +1086,8 @@ def __geo_interface__(self) -> GeoCollectionInterface: # type: ignore [override | |||
} | |||
|
|||
def _prepare_hull(self) -> Iterable[Point2D]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider using 'yield from' instead of chain.from_iterable for simpler and more efficient iteration
Using 'yield from' provides a more straightforward and memory-efficient way to flatten nested iterables compared to chain.from_iterable.
def _prepare_hull(self) -> Iterable[Point2D]:
for geom in self.geoms:
yield from geom._prepare_hull() # noqa: SLF001
PR Code Suggestions ✨Explore these optional code suggestions:
|
Failed to generate code suggestions for PR |
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 2c889df in 1 minute and 53 seconds
More details
- Looked at
822
lines of code in18
files - Skipped
0
files when reviewing. - Skipped posting
8
drafted comments based on config settings.
1. .github/workflows/run-all-tests.yml:71
- Draft comment:
Ensure that the update tocodecov-action@v5
is compatible with your current configuration, as major version updates may introduce breaking changes. - Reason this comment was not posted:
Comment did not seem useful.
2. .github/workflows/run-all-tests.yml:100
- Draft comment:
Verify that the change toruff format --check
andruff check --no-fix
aligns with the intended linting behavior, as this modifies how ruff is executed. - Reason this comment was not posted:
Comment did not seem useful.
3. .github/workflows/run-all-tests.yml:168
- Draft comment:
Ensure thatpypa/gh-action-pypi-publish@release/v1
is compatible with your current workflow and secrets configuration, as this action handles package publishing. - Reason this comment was not posted:
Comment did not seem useful.
4. .github/workflows/run-all-tests.yml:191
- Draft comment:
Ensure thatpypa/gh-action-pypi-publish@release/v1
is compatible with your current workflow and secrets configuration, as this action handles package publishing. - Reason this comment was not posted:
Marked as duplicate.
5. .pre-commit-config.yaml:7
- Draft comment:
Ensure that the update topre-commit-hooks
versionv5.0.0
is compatible with your current configuration, as major version updates may introduce breaking changes. - Reason this comment was not posted:
Marked as duplicate.
6. .pre-commit-config.yaml:44
- Draft comment:
Ensure that the update toruff-pre-commit
versionv0.8.1
is compatible with your current configuration, as version updates may introduce changes. - Reason this comment was not posted:
Comment did not seem useful.
7. .pre-commit-config.yaml:49
- Draft comment:
Ensure that the update toflake8
version7.1.1
is compatible with your current configuration, as version updates may introduce changes. - Reason this comment was not posted:
Marked as duplicate.
8. .pre-commit-config.yaml:72
- Draft comment:
Ensure that the update tomypy
versionv1.13.0
is compatible with your current configuration, as version updates may introduce changes. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_GXHaInce321wl0Fb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto Pull Request Review from LlamaPReview
Large PR Notification
Dear contributor,
Thank you for your substantial contribution to this project. LlamaPReview has detected that this Pull Request contains a large volume of changes, which exceeds our current processing capacity.
Details:
- PR and related contents total size: Approximately 57,871 characters
- Current limit: 50,000 characters
Next steps:
- Consider breaking this PR into smaller, more focused changes if possible.
- For manual review, please reach out to your team members or maintainers.
We appreciate your understanding and commitment to improving this project. Your contributions are valuable, and we want to ensure they receive the attention they deserve.
LlamaPReview is continuously evolving to better serve the community. Share your thoughts on handling large PRs in our GitHub Discussions - your feedback helps us improve and expand our capabilities.
If you have any questions or need assistance, our community and support team are here to help.
Best regards,
LlamaPReview Team
CI Failure Feedback 🧐(Checks updated until commit 1fbadeb)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
Preparing review... |
Preparing review... |
User description
PR Type
enhancement, tests, documentation
Description
sphinx.ext.viewcode
.force_2d
andforce_3d
factories in the top-level module.ruff-format
.Changes walkthrough 📝
2 files
conf.py
Enhance Sphinx documentation with GitHub integration
docs/conf.py
sphinx.ext.viewcode
to Sphinx extensions.README.rst
Update badges and links in README
README.rst
3 files
__init__.py
Expose additional factories in top-level module
pygeoif/init.py
force_2d
andforce_3d
factories in the top-level module.factories.py
Enhance WKT parsing and update copyright
pygeoif/factories.py
split_wkt_components
function for WKT parsing.geometry.py
Improve WKT output and refactor methods
pygeoif/geometry.py
_prepare_hull
method for clarity.3 files
about.py
Bump version to 1.5.1
pygeoif/about.py
run-all-tests.yml
Update CI workflows and add Python 3.14
.github/workflows/run-all-tests.yml
.pre-commit-config.yaml
Update pre-commit hooks and add ruff-format
.pre-commit-config.yaml
ruff-format
hook.3 files
feature.py
Code formatting improvements
pygeoif/feature.py
functions.py
Code formatting improvements
pygeoif/functions.py
types.py
Code formatting improvements
pygeoif/types.py
4 files
strategies.py
Enhance hypothesis strategy for nested collections
pygeoif/hypothesis/strategies.py
test_factories.py
Update tests for WKT output
tests/test_factories.py
test_geometrycollection.py
Update tests for nested GeometryCollections
tests/test_geometrycollection.py
test_multipoint.py
Update tests for WKT output
tests/test_multipoint.py