Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python upgrade to use memory views #9

Merged
merged 8 commits into from
Dec 14, 2024
Merged

python upgrade to use memory views #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
334a024
update format ruff
Dec 9, 2024
429ed4a
pyproject bump to cython version 3 (<3.1)
Dec 9, 2024
c7a0d09
update to use mememoryview and remove cpdef
Dec 9, 2024
82967df
moved setup.py to legacy status
Dec 9, 2024
4574965
start switch to ver 0.86 pyproject.toml
Dec 10, 2024
1d88236
use cython3 .c
Dec 10, 2024
3dc7340
simplified setup.py to work with pyproject.toml
Dec 14, 2024
8389ed1
Update README.rst
cleemesser Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ Status
This is currently "research quality" code. I initially developed it for my
limited purposes to read a few dozen EEGs for a research project. It is inching
towards respectability as it is being updated as we have project that needs it to process
through tens of thousands of edf files.
through tens of thousands of edf files.

It still more needs tests, more refractoring to make a
real pythonic api before heading to towards a polished package.
It still needs more tests and refactoring to make a
real pythonic api before heading to towards a polished package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Remove duplicate word 'to'

The phrase 'to towards' contains a duplicate word - it should be either 'heading to' or 'heading towards'

Suggested change
real pythonic api before heading to towards a polished package.
real pythonic api before heading towards a polished package.


I am currently updating edfwriter for 0.8 as I will be needing to use this functionality again.

Expand Down Expand Up @@ -77,7 +77,7 @@ and writer classes.

Related Projects
----------------
* `pyedf is a fork of this project with some nice work and documentation <https://github.com/holgern/pyedflib>`_.
* `pyedflib is a fork of this project with some nice work and documentation <https://github.com/holgern/pyedflib>`_.
* Robert Oostenveld wrote `bids-standard/pyedf <https://github.com/bids-standard/pyedf>`_, which is a pure python implementation of the standard.
* Teuniz wrote his own python library as well at https://gitlab.com/Teuniz/EDFlib-Python

Expand All @@ -88,7 +88,7 @@ Change list
2018-10-08 created mirror of code on github at https://github.com/cleemesser/python-edf
2018-10-08 added wraps for writing shorts, bump edflib version to 116
2018-02-15 noted that edflib.h not included in source package added to extension file list for 0.74
2017-03-22 added bitbucket-piplines.yml and got integration tests running
2017-03-22 added bitbucket-piplines.yml and got integration tests running
2017-03-22 update properties to modern (python 3) syntax in _edflib. Make distinction clear. Add tests.
2017-03 tweaks to api, python 3 working: will try for dual compatible code python 2.7 + python 3.5+ support
2015-06 update to edflib 1.11
Expand All @@ -100,17 +100,17 @@ I am currently working on using setuptools and the pyproject.toml file to make i
Install/Packing Status:

On ubuntu 20.04 with gcc installed:
- pip install <path-to-cloned-git-repo> # works with setuptools branch
- pip install <path-to-cloned-git-repo> # works with setuptools branch

- with pip 21.2.2 python=3.7; pip 21.2.4 python=3.8, python=3.9, python=3.10

pip install edflib # works to install edflib 0.84.1 from source distribution

- windows install worked

To upload to pypi::
python -m build

twine upload -r legacypypi dist/* <- fix this>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Clean up the command line instruction

The '<- fix this>' comment should either be removed or replaced with a proper explanation of what needs to be fixed

Suggested change
twine upload -r legacypypi dist/* <- fix this>
twine upload -r legacypypi dist/*


Todo:
Expand All @@ -126,7 +126,7 @@ Todo:
- [x] set up continuous build/integration if possible - done on bitbucket for py 3.5 but not yet for github
- [x] incorporate edflib code for utf-8 and short (int16) vs int (int32) digital writes
- [ ] test edflib code for utf-8 and short (int16) vs int (int32) digital writes
- [x] create mirror on github
- [x] create mirror on github
- [ ] investigate manylinux solution to wheels. [PEP 513](https://www.python.org/dev/peps/pep-0513/) and
- [/] fix python packaging problems so that pip installs work again
- progress: as of 0.84 have sdist installs working on linux
Expand Down
4 changes: 3 additions & 1 deletion edflib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
from __future__ import print_function, division, absolute_import

from .edfwriter import EdfWriter
from .edfreader import (Edfinfo, EdfReader)
from .edfreader import Edfinfo, EdfReader

__version__= "0.86.0"
Loading