Fix noisy deprecations sdk node (#1856)

* chore(backend,clerk-sdk-node): Fix always showing deprecation warning for frontendApi * chore(clerk-sdk-node): Fix always showing deprecation warning for apiKey
clerk · Oct 10, 2023 · 3848f8d · 3848f8d
1 parent 7fb2296
commit 3848f8d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/tasty-toes-pump.md b/.changeset/tasty-toes-pump.md
@@ -0,0 +1,6 @@
+---
+'@clerk/clerk-sdk-node': patch
+'@clerk/backend': patch
+---
+
+Avoid always showing deprecation warnings for `frontendApi` and `apiKey` in `@clerk/clerk-sdk-node`
diff --git a/packages/backend/src/tokens/factory.ts b/packages/backend/src/tokens/factory.ts
@@ -104,7 +104,7 @@ export function createAuthenticateRequest(params: CreateAuthenticateRequestOptio
       apiUrl,
       frontendApi: runtimeFrontendApi || buildtimeFrontendApi,
       publishableKey: runtimePublishableKey || buildtimePublishableKey,
-      proxyUrl: (runtimeProxyUrl || buildProxyUrl) as any,
+      proxyUrl: runtimeProxyUrl || buildProxyUrl,
       isSatellite: runtimeIsSatellite || buildtimeIsSatellite,
       domain: (runtimeDomain || buildtimeDomain) as any,
       userAgent: runtimeUserAgent || buildUserAgent,

diff --git a/packages/sdk-node/src/authenticateRequest.ts b/packages/sdk-node/src/authenticateRequest.ts
@@ -20,7 +20,9 @@ export async function loadInterstitial({
    */
   if (requestState.publishableKey || requestState.frontendApi) {
     return clerkClient.localInterstitial({
-      frontendApi: requestState.frontendApi,
+      // Use frontendApi only when legacy frontendApi is used to avoid showing deprecation warning
+      // since the requestState always contains the frontendApi constructed by publishableKey.
+      frontendApi: requestState.publishableKey ? '' : requestState.frontendApi,
       publishableKey: requestState.publishableKey,
       proxyUrl: requestState.proxyUrl,
       signInUrl: requestState.signInUrl,

diff --git a/packages/sdk-node/src/utils.ts b/packages/sdk-node/src/utils.ts
@@ -26,7 +26,7 @@ export const loadClientEnv = () => {
 export const loadApiEnv = () => {
   return {
     secretKey: process.env.CLERK_SECRET_KEY || process.env.CLERK_API_KEY || '',
-    apiKey: process.env.CLERK_SECRET_KEY || process.env.CLERK_API_KEY || '',
+    apiKey: process.env.CLERK_API_KEY || '',
     apiUrl: process.env.CLERK_API_URL || 'https://api.clerk.dev',
     apiVersion: process.env.CLERK_API_VERSION || 'v1',
     domain: process.env.CLERK_DOMAIN || '',