fix(repo): Standardize ambient global.d.ts (#4919)

.changeset/weak-rivers-clean.md

@@ -0,0 +1,15 @@
+---
+'@clerk/chrome-extension': patch
+'@clerk/tanstack-start': patch
+'@clerk/react-router': patch
+'@clerk/clerk-js': patch
+'@clerk/elements': patch
+'@clerk/express': patch
+'@clerk/shared': patch
+'@clerk/astro': patch
+'@clerk/clerk-react': patch
+'@clerk/remix': patch
+'@clerk/clerk-expo': patch
+---
+
+Standardizing ambient declaration files for all SDKs

packages/astro/.gitignore

@@ -32,4 +32,4 @@ pnpm-debug.log*
 *.d.ts.map
 !env.d.ts
 !client.d.ts
-!globals.d.ts
+!global.d.ts

packages/astro/src/global.d.ts

@@ -0,0 +1,2 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;

packages/chrome-extension/src/global.d.ts

@@ -0,0 +1,3 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;
+declare const __DEV__: boolean;

packages/clerk-js/src/global.d.ts

@@ -3,4 +3,22 @@ declare module '@clerk/ui/styles.css' {
   export default content;
 }
 
+declare module '*.svg' {
+  const value: React.FC<React.SVGAttributes<SVGElement>>;
+  export default value;
+}
+
 declare const BUILD_ENABLE_NEW_COMPONENTS: string;
+declare const __PKG_NAME__: string;
+declare const __PKG_VERSION__: string;
+declare const __DEV__: boolean;
+
+/**
+ * Build time feature flags.
+ */
+declare const __BUILD_DISABLE_RHC__: string;
+
+interface Window {
+  __unstable__onBeforeSetActive: () => Promise<void> | void;
+  __unstable__onAfterSetActive: () => Promise<void> | void;
+}

packages/clerk-js/src/ui/common/BlockButtons.tsx

@@ -25,6 +25,7 @@ export const AddBlockButton = (props: BlockButtonProps) => {
       sx={theme => ({ justifyContent: 'flex-start', gap: theme.space.$2 })}
       leftIcon={
         <Icon
+          /* @ts-expect-error FIXME: icon prop typing */
           icon={leftIcon || Plus}
           sx={theme => ({
             width: theme.sizes.$2x5,

packages/clerk-js/src/ui/elements/Select.tsx

@@ -425,6 +425,7 @@ export const SelectButton = (
         elementDescriptor={descriptors.selectButtonIcon}
         elementId={descriptors.selectButtonIcon.setId(elementId)}
         size='md'
+        /* @ts-expect-error FIXME: icon prop typing */
         icon={icon || ChevronDown}
         sx={iconSx}
       />

packages/elements/src/types/global.d.ts

@@ -0,0 +1,3 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;
+declare const __DEV__: boolean;

packages/expo/src/global.d.ts

@@ -0,0 +1,2 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;

packages/express/src/global.d.ts

@@ -0,0 +1,2 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;

packages/express/tsconfig.json

@@ -19,5 +19,5 @@
     "types": ["jest"]
   },
   "exclude": ["node_modules"],
-  "include": ["src/index.ts", "src/globals.d.ts"]
+  "include": ["src/index.ts", "src/global.d.ts"]
 }

packages/react-router/src/global.d.ts

@@ -0,0 +1,2 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;

packages/react/src/global.d.ts

@@ -0,0 +1,9 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;
+declare const JS_PACKAGE_VERSION: string;
+declare const __DEV__: boolean;
+
+declare module globalThis {
+  // eslint-disable-next-line no-var
+  var __BUILD_DISABLE_RHC__: boolean;
+}

packages/react/src/isomorphicClerk.ts

@@ -61,7 +61,7 @@ import type {
 } from './types';
 import { isConstructor } from './utils';
 
-if (typeof __BUILD_DISABLE_RHC__ === 'undefined') {
+if (typeof globalThis.__BUILD_DISABLE_RHC__ === 'undefined') {
   globalThis.__BUILD_DISABLE_RHC__ = false;
 }
 

packages/react/tsconfig.test.json

@@ -8,6 +8,6 @@
     "importHelpers": false,
     "sourceMap": true
   },
-  "include": ["src/globals.d.ts", "src/**/*.test.ts", "src/**/*.test.tsx"],
+  "include": ["src/global.d.ts", "src/**/*.test.ts", "src/**/*.test.tsx"],
   "exclude": []
 }

packages/remix/src/global.d.ts

@@ -0,0 +1,2 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;

packages/shared/global.d.ts

@@ -1,7 +1,4 @@
-export {};
-
-declare global {
-  const PACKAGE_VERSION: string;
-  const JS_PACKAGE_VERSION: string;
-  const __DEV__: boolean;
-}
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;
+declare const JS_PACKAGE_VERSION: string;
+declare const __DEV__: boolean;

packages/tanstack-start/src/global.d.ts

@@ -0,0 +1,4 @@
+declare const PACKAGE_NAME: string;
+declare const PACKAGE_VERSION: string;
+declare const __DEV__: boolean;
+declare const JS_PACKAGE_VERSION: string;