Support audience option in authenticate request
#1004
Conversation
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
packages/backend/src/tokens/jwt.ts
Outdated
| @@ -148,31 +152,39 @@ export async function verifyJwt( | |||
| } | |||
|
|
|||
| // Verify audience claim (aud) | |||
| if (typeof aud === 'string') { | |||
| if (aud !== audience) { | |||
| const audiences = audience && Array.isArray(audience) ? audience : [audience]; | |||
There was a problem hiding this comment.
@dimkl we can simplify the checks by wrapping the audience claim (string or string[]) and then do audiences = [audience].flat().filter(aud => !!aud). That way, the following checks will need to assert only on array emptiness.
There was a problem hiding this comment.
Please review the assertions.test.ts to verify the expected behaviour of our verification audience implementation.
There was a problem hiding this comment.
@SokratisVidros are we okay with the tests and the expected behaviour? If so, i will proceed with merging this.
dimkl
force-pushed
the
issue-978
branch
2 times, most recently
from
bc0c178
to
c72a9f5
Compare
dimkl
force-pushed
the
issue-978
branch
2 times, most recently
from
edda3c4
to
c4d7ad0
Compare
|
@dimkl Is this ready for a final review? |
Yes. A rebase is required before merge but the implementation is finalized. |
dimkl
force-pushed
the
issue-978
branch
3 times, most recently
from
b1e0da4
to
2a8b4e9
Compare
dimkl
force-pushed
the
issue-978
branch
5 times, most recently
from
4d6a00d
to
aa1ab98
Compare
dimkl
force-pushed
the
issue-978
branch
3 times, most recently
from
942c258
to
84f0ea2
Compare
dimkl
force-pushed
the
issue-978
branch
3 times, most recently
from
265d940
to
5042091
Compare
🦋 Changeset detectedLatest commit: ce2e061 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Also there was some changes in the code: - aud claim with empty values does NOT throw verification error
dimkl
force-pushed
the
issue-978
branch
2 times, most recently
from
d71e341
to
6afa5ec
Compare
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastifygatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.manual testing
unit tests