chore(repo): Move error helpers to shared package #1308
Conversation
🦋 Changeset detectedLatest commit: 48f5a30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
| @@ -9,7 +9,7 @@ export type { | |||
| WithClerkProp, | |||
| WithSessionProp, | |||
| } from './types'; | |||
| export { isMagicLinkError, MagicLinkErrorCode } from './errors'; | |||
| export { MagicLinkErrorCode, isClerkAPIResponseError, isKnownError, isMetamaskError, isMagicLinkError } from './errors'; | |||
There was a problem hiding this comment.
❓ Why not export them directly from the @clerk/shared instead of ./errors ?
There was a problem hiding this comment.
It just seemed cleaner to have all error related stuff in one place. Does the other way around seem better to you?
| MagicLinkError, | ||
| ClerkAPIResponseError, | ||
| } from '@clerk/shared'; | ||
| export type { MetamaskError } from '@clerk/shared'; |
There was a problem hiding this comment.
❓ Why not use them directly from the @clerk/shared and drop this file?
There was a problem hiding this comment.
We export them twice so I thought it was better to have the logic here.
desiprisg
force-pushed
the
george/js-390-export-clerk-errors-and-isclerkapiresponseerror-helpers-via
branch
2 times, most recently
from
41900bb
to
26a5cc5
Compare
test(chrome-extension): Update shapshots
desiprisg
force-pushed
the
george/js-390-export-clerk-errors-and-isclerkapiresponseerror-helpers-via
branch
from
26a5cc5
to
48f5a30
Compare
nikosdouvlis
deleted the
george/js-390-export-clerk-errors-and-isclerkapiresponseerror-helpers-via
branch
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.