feat(nextjs): Detect infinite interstitial redirect loop in middleware #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 64bc208 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
When in development, we want to prevent infinite interstitial redirection loops. We incrementally set a `__clerk_redirection_loop` cookie, and after looping 6 times, we throw an error. We also utilize the `referer` header to skip the prefetch requests.
anagstef
force-pushed
the
stefanos/js-169-catch-infinite-redirects-and-inform-the-developer
branch
from
c9a0ec8
to
5fede9e
Compare
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
|
!snapshot |
|
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.22.0-snap.5fede9e# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.8-snap.5fede9e# @clerk/clerk-js
npm i @clerk/clerk-js@4.45.1-snap.5fede9e# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.17.8-snap.5fede9e# @clerk/fastify
npm i @clerk/fastify@0.4.6-snap.5fede9e# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.7-snap.5fede9e# @clerk/localizations
npm i @clerk/localizations@1.17.1-snap.5fede9e# @clerk/nextjs
npm i @clerk/nextjs@4.20.0-snap.5fede9e# @clerk/clerk-react
npm i @clerk/clerk-react@4.19.0-snap.5fede9e# @clerk/remix
npm i @clerk/remix@2.6.6-snap.5fede9e# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.4-snap.5fede9e# @clerk/shared
npm i @clerk/shared@0.18.0-snap.5fede9e# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.41.1-snap.5fede9e |
…-inform-the-developer
…ion loops detection
…-inform-the-developer
anagstef
force-pushed
the
stefanos/js-169-catch-infinite-redirects-and-inform-the-developer
branch
from
f9f17ab
to
fce5282
Compare
…-inform-the-developer
anagstef
deleted the
stefanos/js-169-catch-infinite-redirects-and-inform-the-developer
branch
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.When in development, we want to prevent infinite interstitial redirection loops.
We incrementally set a
__clerk_redirection_loopcookie, and after looping 6 times, we throw an error.We also utilize the
refererheader to skip the prefetch requests.