fix(backend): Make all 4 keys (legacy and new) optional in authenticateRequest
#1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8db061c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
|
!snapshot |
|
Hey @anagstef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.7-snapshot.ff9370c# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.19-snapshot.ff9370c# @clerk/clerk-js
npm i @clerk/clerk-js@4.51.0# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.10-snapshot.ff9370c# @clerk/fastify
npm i @clerk/fastify@0.5.6-snapshot.ff9370c# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.19-snapshot.ff9370c# @clerk/localizations
npm i @clerk/localizations@1.22.0# @clerk/nextjs
npm i @clerk/nextjs@4.21.13-snapshot.ff9370c# @clerk/clerk-react
npm i @clerk/clerk-react@4.21.1-snapshot.ff9370c# @clerk/remix
npm i @clerk/remix@2.6.16-snapshot.ff9370c# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.14-snapshot.ff9370c# @clerk/shared
npm i @clerk/shared@0.19.1# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.46.1 |
anagstef
force-pushed
the
fix_authenticate_request_params_type
branch
from
ff9370c
to
a252412
Compare
anagstef
changed the title
authenticateRequest
|
!snapshot |
|
Hey @anagstef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.7-snapshot.a252412# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.19-snapshot.a252412# @clerk/clerk-js
npm i @clerk/clerk-js@4.51.0# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.10-snapshot.a252412# @clerk/fastify
npm i @clerk/fastify@0.5.6-snapshot.a252412# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.19-snapshot.a252412# @clerk/localizations
npm i @clerk/localizations@1.22.0# @clerk/nextjs
npm i @clerk/nextjs@4.21.13-snapshot.a252412# @clerk/clerk-react
npm i @clerk/clerk-react@4.21.1-snapshot.a252412# @clerk/remix
npm i @clerk/remix@2.6.16-snapshot.a252412# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.14-snapshot.a252412# @clerk/shared
npm i @clerk/shared@0.19.1# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.46.1 |
| @@ -189,7 +189,7 @@ async function verifyRequestState(options: AuthenticateRequestOptions, token: st | |||
| export const isSatelliteAndNeedsSyncing: InterstitialRule = options => { | |||
| const { clientUat, isSatellite, searchParams, secretKey, apiKey, userAgent } = options; | |||
|
|
|||
| const key = secretKey || apiKey; | |||
| const key = (secretKey || apiKey) as string; | |||
There was a problem hiding this comment.
isn't wrong to assume this will work ? How about this instead ?
Suggested change
| const key = (secretKey || apiKey) as string; | |
| const key = secretKey || apiKey || ''; |
There was a problem hiding this comment.
Changed all the occurrences!
anagstef
force-pushed
the
fix_authenticate_request_params_type
branch
from
a252412
to
8db061c
Compare
nikosdouvlis
approved these changes
Jun 29, 2023
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Make all 4 keys (legacy and new) optional in
authenticateRequest. That will make the@clerk/backendeasier to use.