feat(remix,backend): Repo level config for remix #1470
Conversation
🦋 Changeset detectedLatest commit: 172838b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
desiprisg
changed the title
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
desiprisg
changed the title
| opts.afterSignUpUrl || | ||
| getEnvVariable('CLERK_AFTER_SIGN_UP_URL') || | ||
| (context?.CLERK_AFTER_SIGN_UP_URL as string) || | ||
| ''; |
There was a problem hiding this comment.
☁️ If we had a centralized config object, probably this (and the 3 following added lines) would have been the change to support the Repo level config for remix. Right?
There was a problem hiding this comment.
We'd also have to include the options in authenticateRequest.
There was a problem hiding this comment.
@dimkl That is correct. We need to bring this up again now that we have 2 packages using repo-level config otherwise, this will become unwieldy
dimkl
force-pushed
the
remix_repo_level_config
branch
from
6ad0da8
to
172838b
Compare
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.This PR implements the repo level config for remix. Had to make some additions to the backend package, so it may be worthwhile to add those params to the other backend packages as well.
remix env example