Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Export SignInWithMetamaskButton #1731

Conversation

octoper
Copy link
Member

@octoper octoper commented Sep 15, 2023

Description

<SignInWithMetamaskButton/> wasn't exported from @clerk/nextjs package.

This PR re-exports it's from @clerk/clerk-react.

Fixes JS-709

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@octoper octoper requested a review from a team as a code owner September 15, 2023 08:43
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

🦋 Changeset detected

Latest commit: 62240be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper changed the title fix(nextjs): Export SignInWithMetamaskButton component fix(nextjs): Export SignInWithMetamaskButton Sep 15, 2023
@octoper octoper self-assigned this Sep 15, 2023
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Great work

.changeset/brown-poets-hang.md Outdated Show resolved Hide resolved
@octoper octoper force-pushed the vaggelis/js-709-signinwithmetamaskbutton-cannot-be-exported-from-clerknextjs branch from f2674fc to 62240be Compare September 15, 2023 11:01
@octoper octoper merged commit 5910f0d into main Sep 15, 2023
5 checks passed
@octoper octoper deleted the vaggelis/js-709-signinwithmetamaskbutton-cannot-be-exported-from-clerknextjs branch September 15, 2023 11:12
@clerk-cookie clerk-cookie mentioned this pull request Sep 15, 2023
Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants