Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Update links in all READMEs #1750

Conversation

LekoArts
Copy link
Member

Description

Follow up to #1709 - The old templates were referenced in the READMEs so the links needed an update.

I also did:

  • Change the Discord link to our clerk.com/discord shortlink so that if in the future the invite expires or somehow doesn't work, we don't need to publish a new version to update the link in the READMEs
  • Our main README uses a light/dark version of the logo depending on the system status. I've updated each README to also use that pattern instead of always the light version
  • I removed two images from the docs folder since they were unused
  • Linked our GitHub discussion for people to ask questions

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • all packages

@LekoArts LekoArts requested review from dimkl and a team as code owners September 20, 2023 09:06
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: 4dcb4b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
gatsby-plugin-clerk Patch
@clerk/chrome-extension Patch
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/clerk-sdk-node Patch
@clerk/backend Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/themes Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/types Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@LekoArts LekoArts merged commit 4327b91 into main Sep 20, 2023
5 checks passed
@LekoArts LekoArts deleted the lekoarts/js-743-change-links-to-report-a-bug-request-feature-in-readmes branch September 20, 2023 09:19
@clerk-cookie clerk-cookie mentioned this pull request Sep 20, 2023
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants